Fix: Handle invalid desktop files gracefully and prevent duplicate entries#9
Open
PGupta-Git wants to merge 1 commit intoimoize:mainfrom
Open
Fix: Handle invalid desktop files gracefully and prevent duplicate entries#9PGupta-Git wants to merge 1 commit intoimoize:mainfrom
PGupta-Git wants to merge 1 commit intoimoize:mainfrom
Conversation
PGupta-Git
changed the title
…tries
This commit addresses two critical bugs in Flickernaut:
1. Extension crash with invalid desktop files (Critical)
- Added try-except error handling in Package.__init__ to gracefully
handle NULL returns from Gio.DesktopAppInfo.new()
- Wrapped Application creation in try-except in manager.py to skip
invalid applications during initialization instead of crashing
- Prevents complete extension failure when a configured app's
desktop file doesn't exist
2. Duplicate entries in preferences app chooser
- Changed show_all from true to false in AppDialog (application.ts)
- This respects the NoDisplay=true setting in URL handler desktop files
- Prevents apps like Positron and Antigravity from appearing twice
(once for main app, once for URL handler)
Files modified:
- nautilus-extension/Flickernaut/models.py: Error handling for NULL desktop files
- nautilus-extension/Flickernaut/manager.py: Skip invalid apps during init
- src/prefs/application.ts: Respect NoDisplay=true setting
Fixes: Extension crashes preventing all context menus from appearing
Fixes: Duplicate application entries in preferences dialog
PGupta-Git
force-pushed
the
fix/handle-invalid-desktop-files
branch
from
2d9f91d to
7c8e3b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses two critical bugs in Flickernaut and fixes the issue that I opened #10:
Extension crash with invalid desktop files (Critical)
Duplicate entries in the preferences app chooser
Files modified:
Fixes: Extension crashes, preventing all context menus from appearing
Fixes: Duplicate application entries in preferences dialogue